Fix(template): Replace hardcoded "rerun" check with loop.last for comma logic#1020
Open
iisenfrank wants to merge 1 commit intopytest-dev:masterfrom
Open
Fix(template): Replace hardcoded "rerun" check with loop.last for comma logic#1020iisenfrank wants to merge 1 commit intopytest-dev:masterfrom
iisenfrank wants to merge 1 commit intopytest-dev:masterfrom
Conversation
…for comma logic The comma condition in the outcomes loop was hardcoded to check `result != "rerun"`, which breaks since pytest-dev#836 added "retried" after "rerun" in the outcomes dict. Using Jinja2's `loop.last` is the correct, order-independent approach. Ref: pytest-dev#836
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded "rerun" check with Jinja2 loop.last for comma logic
The comma condition in the outcomes loop was hardcoded to check
result != "rerun", which breaks since #836 added "retried" after "rerun" in the outcomes dict. Using Jinja2'sloop.lastis the correct, order-independent approach.